Fix/md parsing #1513
Merged
Fix/md parsing #1513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently tried tackling a bug in our markdown syntax highlighting which was not detecting the end of a quote (as indicated by an empty line) correctly. I then tried to fix this by updating the markdown mode code that we reuse from codemirror5.
However, we then found out that the newer markdown code requires some more fundamental changes to the glue code in which we plug the editor modes in, as the new mode crashed for example when visiting a
!.Thus, I reverted the update and fixed the underlying bug in the quote end detection which came to be as we did not pass empty lines to the parser correctly but just skipped them. Thus, empty lines in markdown could never reset the current style correctly.
This is not the only issue with the markdown syntax highlighting, but the most severe one.
Upgrading to the more modern codemirror5 md mode or even to the one from codemirror6 requires significantly more work, which I why postpone it indefinitely.
Closes #1512.